search

datastrato / gravitino

World's most powerful open data catalog for building a high-performance, geo-distributed and federated metadata lake.
https://datastrato.ai/docs/
Apache License 2.0
609 stars 193 forks source link

[#299] improve(test): Supplemental e2e coverage test #463

Closed justinmclean closed 7 months ago

justinmclean commented 8 months ago

What changes were proposed in this pull request?

Added more end to end integration tests.

Why are the changes needed?

To confirm we have working software.

Fix: #299

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Tests run on local machine using docker. Note that currently 4 tests are failing due to bugs:

TableHiveIT > testTableDeleteUnknownColumn() FAILED TableHiveIT > testTableColumnUpdatePositionToFirst() FAILED TableHiveIT > testTableColumnUpdatePositionToLast() FAILED TableHiveIT > testTableColumnUpdateDatatypeNullability() FAILED

github-actions[bot] commented 8 months ago

Code Coverage Report

Overall Project 62.02% -7.79% :green_circle:
Files changed 59.73% :red_circle:


Module Coverage
server-common 88.1% -7.46% :green_circle:
server 87.99% :green_circle:
catalog-lakehouse-iceberg 80.5% -11.75% :green_circle:
core 74.24% -6.27% :green_circle:
api 68.43% -1.24% :red_circle:
catalog-hive 65.46% -2.06% :green_circle:
common 41.98% -0.62% :green_circle:
trino-connector 21.11% -62.32% :red_circle:
Files |Module|File|Coverage|| |:-|:-|:-|:-:| |server-common|[JettyServerConfig.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/server-common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fserver%2Fweb%2FJettyServerConfig.java)|100%|:green_circle:| ||[JettyServer.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/server-common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fserver%2Fweb%2FJettyServer.java)|80.87% **`-11.99%`**|:green_circle:| |server|[ServerConfig.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fserver%2FServerConfig.java)|100%|:green_circle:| ||[TableOperations.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fserver%2Fweb%2Frest%2FTableOperations.java)|96.2%|:green_circle:| ||[GravitonServer.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/server%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fserver%2FGravitonServer.java)|50.8%|:green_circle:| |catalog-lakehouse-iceberg|[IcebergConfigOperations.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2Fweb%2Frest%2FIcebergConfigOperations.java)|100%|:green_circle:| ||[IcebergConfig.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2FIcebergConfig.java)|100%|:green_circle:| ||[IcebergCatalogUtil.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2Futils%2FIcebergCatalogUtil.java)|97.25%|:green_circle:| ||[ConvertUtil.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2Fconverter%2FConvertUtil.java)|94.83% **`-5.17%`**|:green_circle:| ||[FromIcebergSortOrder.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2Fconverter%2FFromIcebergSortOrder.java)|94.35% **`-5.65%`**|:green_circle:| ||[IcebergColumn.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2FIcebergColumn.java)|94.12% **`-5.88%`**|:green_circle:| ||[IcebergTableOps.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2Fops%2FIcebergTableOps.java)|90.53%|:green_circle:| ||[IcebergTableOpsHelper.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2Fops%2FIcebergTableOpsHelper.java)|89.51%|:green_circle:| ||[FromIcebergPartitionSpec.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2Fconverter%2FFromIcebergPartitionSpec.java)|86.3% **`-13.7%`**|:green_circle:| ||[IcebergTable.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2FIcebergTable.java)|84.98% **`-15.02%`**|:green_circle:| ||[ToIcebergType.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2Fconverter%2FToIcebergType.java)|83.47% **`-16.53%`**|:green_circle:| ||[IcebergSchema.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2FIcebergSchema.java)|81.33%|:green_circle:| ||[ToIcebergTypeVisitor.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2Fconverter%2FToIcebergTypeVisitor.java)|79.59% **`-20.41%`**|:green_circle:| ||[IcebergCatalogOperations.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2FIcebergCatalogOperations.java)|76.53% **`-11.61%`**|:green_circle:| ||[ToIcebergSortOrder.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2Fconverter%2FToIcebergSortOrder.java)|69.31% **`-30.69%`**|:green_circle:| ||[FromIcebergType.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2Fconverter%2FFromIcebergType.java)|69.23% **`-30.77%`**|:green_circle:| ||[ToIcebergPartitionSpec.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2Fconverter%2FToIcebergPartitionSpec.java)|57.69% **`-42.31%`**|:red_circle:| ||[IcebergRESTService.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2FIcebergRESTService.java)|0% **`-26.72%`**|:red_circle:| ||[IcebergTablePropertiesMetadata.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-lakehouse-iceberg%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Flakehouse%2Ficeberg%2FIcebergTablePropertiesMetadata.java)|0%|:red_circle:| |core|[EntityStore.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2FEntityStore.java)|100%|:green_circle:| ||[BasePropertiesMetadata.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2FBasePropertiesMetadata.java)|98.57% **`-1.43%`**|:green_circle:| ||[Entity.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2FEntity.java)|96.94%|:green_circle:| ||[KvEntityStore.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fstorage%2Fkv%2FKvEntityStore.java)|94.13%|:green_circle:| ||[EntityCombinedTable.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Frel%2FEntityCombinedTable.java)|92.52%|:green_circle:| ||[CatalogOperationDispatcher.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2FCatalogOperationDispatcher.java)|88.19% **`-6.34%`**|:green_circle:| ||[BaseCatalog.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2FBaseCatalog.java)|75.9% **`-5.42%`**|:green_circle:| ||[PropertiesMetadata.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2FPropertiesMetadata.java)|72.49% **`-27.51%`**|:green_circle:| ||[AuditInfo.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fmeta%2FAuditInfo.java)|71.99%|:green_circle:| ||[CatalogManager.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2FCatalogManager.java)|61.73% **`-18.48%`**|:red_circle:| ||[AuxiliaryServiceManager.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Faux%2FAuxiliaryServiceManager.java)|59.76% **`-0.72%`**|:green_circle:| ||[PropertyEntry.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2FPropertyEntry.java)|57.25% **`-42.75%`**|:red_circle:| ||[IsolatedClassLoader.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Futils%2FIsolatedClassLoader.java)|41.41% **`-26.04%`**|:red_circle:| ||[BaseCatalogPropertiesMetadata.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/core%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2FBaseCatalogPropertiesMetadata.java)|0%|:red_circle:| |api|[TableChange.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/api%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Frel%2FTableChange.java)|85.09%|:green_circle:| ||[Transforms.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/api%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Frel%2Ftransforms%2FTransforms.java)|51.65% **`-11.54%`**|:red_circle:| |catalog-hive|[HiveCatalogPropertiesMeta.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-hive%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Fhive%2FHiveCatalogPropertiesMeta.java)|100%|:green_circle:| ||[HiveTablePropertiesMetadata.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-hive%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Fhive%2FHiveTablePropertiesMetadata.java)|98.8% **`-1.2%`**|:green_circle:| ||[HiveTable.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-hive%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Fhive%2FHiveTable.java)|93.9% **`-3.99%`**|:green_circle:| ||[HiveCatalogOperations.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/catalogs%2Fcatalog-hive%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fcatalog%2Fhive%2FHiveCatalogOperations.java)|69.91% **`-4.04%`**|:green_circle:| |common|[ConfigEntry.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fconfig%2FConfigEntry.java)|91.08%|:green_circle:| ||[MapUtils.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Futils%2FMapUtils.java)|89.29%|:green_circle:| ||[SimplePartitionDTO.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fdto%2Frel%2FSimplePartitionDTO.java)|74.59% **`-2.16%`**|:green_circle:| ||[ConfigBuilder.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fconfig%2FConfigBuilder.java)|73.95%|:green_circle:| ||[ExpressionPartitionDTO.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fdto%2Frel%2FExpressionPartitionDTO.java)|69.49% **`-0.71%`**|:green_circle:| ||[ListPartitionDTO.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fdto%2Frel%2FListPartitionDTO.java)|64.98% **`-1.08%`**|:red_circle:| ||[RangePartitionDTO.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fdto%2Frel%2FRangePartitionDTO.java)|64.04% **`-1.37%`**|:red_circle:| ||[PartitionUtils.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Fdto%2Frel%2FPartitionUtils.java)|51.75% **`-9.3%`**|:green_circle:| ||[Config.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/common%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2FConfig.java)|37.3%|:green_circle:| |trino-connector|[GravitonErrorCode.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2FGravitonErrorCode.java)|100%|:green_circle:| ||[DataTypeTransformer.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2Futil%2FDataTypeTransformer.java)|95.26% **`-4.74%`**|:green_circle:| ||[GravitonColumn.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2Fmetadata%2FGravitonColumn.java)|66.67% **`-33.33%`**|:green_circle:| ||[GravitonSchema.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2Fmetadata%2FGravitonSchema.java)|66.67% **`-33.33%`**|:green_circle:| ||[GravitonCatalog.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2Fmetadata%2FGravitonCatalog.java)|63.64%|:green_circle:| ||[GravitonTable.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2Fmetadata%2FGravitonTable.java)|46.15% **`-53.85%`**|:red_circle:| ||[GravitonTableHandle.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2FGravitonTableHandle.java)|37.86% **`-62.14%`**|:red_circle:| ||[HiveTableProperties.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2Fcatalog%2Fhive%2FHiveTableProperties.java)|0%|:red_circle:| ||[HiveSchemaProperties.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2Fcatalog%2Fhive%2FHiveSchemaProperties.java)|0%|:red_circle:| ||[HiveMetadataAdapter.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2Fcatalog%2Fhive%2FHiveMetadataAdapter.java)|0%|:red_circle:| ||[HiveConnectorAdapter.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2Fcatalog%2Fhive%2FHiveConnectorAdapter.java)|0%|:red_circle:| ||[CatalogConnectorFactory.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2Fcatalog%2FCatalogConnectorFactory.java)|0% **`-93.81%`**|:red_circle:| ||[CatalogConnectorManager.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2Fcatalog%2FCatalogConnectorManager.java)|0% **`-7.52%`**|:red_circle:| ||[CatalogConnectorMetadata.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2Fcatalog%2FCatalogConnectorMetadata.java)|0%|:red_circle:| ||[CatalogConnectorContext.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2Fcatalog%2FCatalogConnectorContext.java)|0% **`-67.23%`**|:red_circle:| ||[CatalogInjector.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2Fcatalog%2FCatalogInjector.java)|0% **`-69.77%`**|:red_circle:| ||[CatalogConnectorAdapter.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2Fcatalog%2FCatalogConnectorAdapter.java)|0%|:green_circle:| ||[GravitonTransactionHandle.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2FGravitonTransactionHandle.java)|0%|:red_circle:| ||[GravitonInsertTableHandle.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2FGravitonInsertTableHandle.java)|0%|:red_circle:| ||[GravitonMetadata.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2FGravitonMetadata.java)|0%|:red_circle:| ||[GravitonConnector.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2FGravitonConnector.java)|0% **`-89.23%`**|:red_circle:| ||[GravitonSplitManager.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2FGravitonSplitManager.java)|0%|:red_circle:| ||[GravitonColumnHandle.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2FGravitonColumnHandle.java)|0%|:red_circle:| ||[GravitonConnectorFactory.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2FGravitonConnectorFactory.java)|0% **`-8.43%`**|:red_circle:| ||[GravitonDataSourceProvider.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2FGravitonDataSourceProvider.java)|0%|:red_circle:| ||[GravitonPageSinkProvider.java](https://github.com/datastrato/graviton/blob/61a898f1f0c033a5033e64b46cbdd463d8194d7b/trino-connector%2Fsrc%2Fmain%2Fjava%2Fcom%2Fdatastrato%2Fgraviton%2Ftrino%2Fconnector%2FGravitonPageSinkProvider.java)|0%|:red_circle:|
justinmclean commented 8 months ago

Can we make an exception for wildcard imports i.e. "import·static·org.junit.jupiter.api.Assertions.*;" in tests?

jerryshao commented 8 months ago

@mchades @xunliu can you please help to review this.

mchades commented 8 months ago

@justinmclean is this PR ready for review? There seems no checks passed.

justinmclean commented 8 months ago

Please see my comment above about the wild card import. Yes, it is ready for review.

mchades commented 8 months ago

Can we make an exception for wildcard imports i.e. "import·static·org.junit.jupiter.api.Assertions.*;" in tests?

I think we should never use import * in either main or test. @jerryshao What's your opinion?

jerryshao commented 8 months ago

I would suggest not making an exception for tests. Firstly, I'm not sure if this exception can be set through Graviton; Secondly, I don't see a persuasive reason to make this as an exception.

yuqi1129 commented 8 months ago

testTableColumnUpdateDatatypeNullability() FAILED

It seems that Hive does not support NOT NULL syntax in column type.

justinmclean commented 8 months ago

@yuqi1129 for NOT NULL if Hive doesn't support it should we not allow it? Currently:

justinmclean commented 8 months ago

@yuqi1129 Looks like we still have an issue with changing columns even when the data types are the same - see testTableColumnSwap.

justinmclean commented 8 months ago

Currently, testTableColumnSwap is failing due to a bug, but this is now ready for review.

mchades commented 8 months ago

Currently, testTableColumnSwap is failing due to a bug, but this is now ready for review.

Could you please provide some error messages?

jerryshao commented 8 months ago

@justinmclean current code introduces many unrelated codes, can you please fix it, thanks.

justinmclean commented 8 months ago

There is no unrelated code I need to merge main to get the tests to pass and to fix conflicts.

mchades commented 8 months ago

There is no unrelated code I need to merge main to get the tests to pass and to fix conflicts.

Please use git rebase main instead, as GitHub indicates that there are 150 files changed in this PR when there are 2 actually, which makes this PR difficult to review. @justinmclean

mchades commented 8 months ago

Should this PR be closed, since #536 was opened. @justinmclean