[#542] feat(trino-connector): package gravitino trino-connector

[yuqi1129]

What changes were proposed in this pull request?

• Package trino-connetor as gravition-trinno-connector-{version}.tar.gz and put it under distribution directory
• Add docs about trino-connector accordingly.

Why are the changes needed?

We need to package trino-connector when releasing Gravitino

Fix: #542

Does this PR introduce any user-facing change?

No

How was this patch tested?

No

[github-actions[bot]]

Code Coverage Report

Overall Project	66.9%	:green_circle:

There is no coverage information present for the Files changed

[jerryshao]

Can you please paste the package structure here?

[jerryshao]

@xunliu @diqiu50 can you please help to review?

[yuqi1129]

Can you please paste the package structure here?

I create a new directory gravitino-trino-connector under the project root like distribution and the folder structure is as follows:

├── gravitino-trino-connector-0.2.0-SNAPSHOT.tar.gz
├── gravitino-trino-connector-0.2.0-SNAPSHOT.tar.gz.sha256
└── libs
    ├── HdrHistogram-2.1.9.jar
    ├── aopalliance-1.0.jar
    ├── bootstrap-235.jar
     ....

[jerryshao]

Can you please paste the package structure here?

I create a new directory gravitino-trino-connector under the project root like distribution and the folder structure is as follows:

├── gravitino-trino-connector-0.2.0-SNAPSHOT.tar.gz
├── gravitino-trino-connector-0.2.0-SNAPSHOT.tar.gz.sha256
└── libs
    ├── HdrHistogram-2.1.9.jar
    ├── aopalliance-1.0.jar
    ├── bootstrap-235.jar
     ....

I think the key point is: a) to release this package conveniently; b) let trino to use it very easily.

[yuqi1129]

Can you please paste the package structure here?

I create a new directory gravitino-trino-connector under the project root like distribution and the folder structure is as follows:

├── gravitino-trino-connector-0.2.0-SNAPSHOT.tar.gz
├── gravitino-trino-connector-0.2.0-SNAPSHOT.tar.gz.sha256
└── libs
    ├── HdrHistogram-2.1.9.jar
    ├── aopalliance-1.0.jar
    ├── bootstrap-235.jar
     ....

I think the key point is: a) to release this package conveniently; b) let trino to use it very easily.

The final structure is like this, is it acceptable?

[yuqi1129]

@xunliu @diqiu50 Please check if the tarball works well for trino connector.

[jerryshao]

What is the unzipped folder name? @yuqi1129

[diqiu50]

Can you please paste the package structure here?

I create a new directory gravitino-trino-connector under the project root like distribution and the folder structure is as follows:

├── gravitino-trino-connector-0.2.0-SNAPSHOT.tar.gz
├── gravitino-trino-connector-0.2.0-SNAPSHOT.tar.gz.sha256
└── libs
    ├── HdrHistogram-2.1.9.jar
    ├── aopalliance-1.0.jar
    ├── bootstrap-235.jar
     ....

I think the key point is: a) to release this package conveniently; b) let trino to use it very easily.

The final structure is like this, is it acceptable?

What's the purpose of the "gravitino-trino-connector" directory.

[yuqi1129]

What is the unzipped folder name?

Decompress the tarball gravitino-trino-connector-0.2.0-SNAPSHOT.tar.gz will get fold gravitino-trino-connector-0.2.0-SNAPSHOT

[jerryshao]

What is the unzipped folder name?

Decompress the tarball gravitino-trino-connector-0.2.0-SNAPSHOT.tar.gz will get fold gravitino-trino-connector-0.2.0-SNAPSHOT

OK, that's fine.

[jerryshao]

I'm OK with the current change, @xunliu @yuqi1129 please review and verify.

[diqiu50]

@xunliu @diqiu50 Please check if the tarball works well for trino connector.

I have checked, it works.

[diqiu50]

I think the name of the directory after unpacking is too long. I suggest using "gravitino".

[jerryshao]

I think the name of the directory after unpacking is too long. I suggest using "gravitino".

Maybe we can tell user to remove the folder name if they think it is too long in doc. As a standalone package, I think the name "gravitino-trino-connector" is OK.

[jerryshao]

@yuqi1129 @diqiu50 what do you think?

[yuqi1129]

@yuqi1129 @diqiu50 what do you think?

I don't think the folder's name is so important, as we can change it during decompression. We use the current name to clearly show that it's the Gravitino trino connector.