Divide by 0 warning. - Githubissues

datasweet / kibana-datasweet-formula

This Kibana plugin allows calculated metrics on any standard kibana visualizations.

Apache License 2.0

121 stars 34 forks source link

Divide by 0 warning. #32

Closed joeyJsonar closed 5 years ago

joeyJsonar commented 5 years ago

Javascript have some weird behaviour concerning division.

0/0 => NaN
x/0 | x <> 0 => -/+Infinity

We want NaN for both.

Our organizationalso wanted to display a Kibana warning when a Divide by 0 occured, just to warn the user. Let them know that something unexpected might be hapenning. Something like the following:

'Divide by 0 occured. If this is unexpected, please ensure the denominator is non-zero.'

Let me know what you think.

guanghaofan commented 5 years ago

can we show all the x/0 as null?