search

datasweet / kibana-datasweet-formula

This Kibana plugin allows calculated metrics on any standard kibana visualizations.
Apache License 2.0
121 stars 34 forks source link

Migration elk 6.5 #34

Closed toog closed 5 years ago

toog commented 5 years ago

Hello

Have you planned to do the migration to Kibana 6.5 soon ?

lfroment-datasweet commented 5 years ago

Hi @toog Yes we will, but we still do not know if some new breaking change could cause some trouble. Stay tuned!

toog commented 5 years ago

Nice

That can help you : https://www.elastic.co/blog/kibana-plugin-api-changes-in-6-5

Thanks

Le 22 nov. 2018 à 12:03, Lionel FROMENT notifications@github.com a écrit :

Hi @toog Yes we will, but we still do not know if some new breaking change could cause some trouble. Stay tuned!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

TraderApophis commented 5 years ago

+1 Hoping for update for this fantastic plugin soon.

Thanks

use-the-fork commented 5 years ago

+1 I love this plugin. But upgraded 6.5.1

Thanks!

pchakour commented 5 years ago

+1 @lfroment-datasweet I made a little patch to upgrade the plugin for kibana 6.5. How can I share it with you ?

use-the-fork commented 5 years ago

@pchakour You can zip it up and attach it to this comment chain or Set up a Google link. One of us can then fork the project and apply your tweak so everyone can use it.

I would love to use it!

pchakour commented 5 years ago

This is a zip which contain a git patch of my commit.

0001-Upgrade-to-kibana-6.5.x.zip

To apply it, you can use the following command : git am < 0001-Upgrade-to-kibana-6.5.x.patch

use-the-fork commented 5 years ago

This is a zip which contain a git patch of my commit.

0001-Upgrade-to-kibana-6.5.x.zip

To apply it, you can use the following command : git am < 0001-Upgrade-to-kibana-6.5.x.patch

Perfect! I went ahead and made a branch and applied your patch worked perfect for me: https://github.com/sincorecom/kibana-datasweet-formula

pchakour commented 5 years ago

Enjoy guys ;) I hope to see this modification in the official repository soon !

lfroment-datasweet commented 5 years ago

Hi all ! Sorry for such a long silence. We are quite busy on something that you could find useful when it is ready ! The release frequency of Elastic is hard to follow for us. Happy to hear that you patched that one successfully @pchakour . We will take a closer look in order to merge it.

simpleuser99 commented 5 years ago

This is a zip which contain a git patch of my commit. 0001-Upgrade-to-kibana-6.5.x.zip To apply it, you can use the following command : git am < 0001-Upgrade-to-kibana-6.5.x.patch

Perfect! I went ahead and made a branch and applied your patch worked perfect for me: https://github.com/sincorecom/kibana-datasweet-formula

Hello! I can not install you fork/ I have the next messages:

Attempting to transfer from file:///home/admin7/plug/sweet/sweet.zip Transferring 12512781 bytes.................... Transfer complete Retrieving metadata from plugin archive Extracting plugin archive Extraction complete Optimizing and caching browser bundles... Plugin installation was unsuccessful due to error "Command failed: /usr/share/kibana/node/bin/node /usr/share/kibana/src/cli --env.name=production --optimize.useBundleCache=false --server.autoListen=false --plugins.initialize=false (node:16275) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead. FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory 1: node::Abort() [/usr/share/kibana/node/bin/node] 2: 0x8cce9c [/usr/share/kibana/node/bin/node] 3: v8::Utils::ReportOOMFailure(char const, bool) [/usr/share/kibana/node/bin/node] 4: v8::internal::V8::FatalProcessOutOfMemory(char const, bool) [/usr/share/kibana/node/bin/node] 5: v8::internal::Factory::NewRawTwoByteString(int, v8::internal::PretenureFlag) [/usr/share/kibana/node/bin/node] 6: v8::internal::String::SlowFlatten(v8::internal::Handle, v8::internal::PretenureFlag) [/usr/share/kibana/node/bin/node] 7: v8::internal::String::Flatten(v8::internal::Handle, v8::internal::PretenureFlag) [/usr/share/kibana/node/bin/node] 8: v8::internal::String::LastIndexOf(v8::internal::Isolate*, v8::internal::Handle, v8::internal::Handle, v8::internal::Handle) [/usr/share/kibana/node/bin/node] 9: v8::internal::Builtin_StringPrototypeLastIndexOf(int, v8::internal::Object*, v8::internal::Isolate) [/usr/share/kibana/node/bin/node] 10: 0x1db0b8d8697d

<--- Last few GCs --->

[16275:0x2d90a20] 713653 ms: Mark-sweep 1298.2 (1470.8) -> 1298.1 (1472.3) MB, 2280.0 / 0.0 ms allocation failure GC in old space requested [16275:0x2d90a20] 715960 ms: Mark-sweep 1298.1 (1472.3) -> 1298.1 (1416.8) MB, 2306.6 / 0.0 ms last resort GC in old space requested [16275:0x2d90a20] 718442 ms: Mark-sweep 1298.1 (1416.8) -> 1298.1 (1415.3) MB, 2482.2 / 0.0 ms last resort GC in old space requested

<--- JS stacktrace --->

==== JS stack trace =========================================

Security context: 0x33921baa58b9 0: builtin exit frame: lastIndexOf(this=0x1231c033b429 <Very long string[6713313]>,0x2aca799120e9 <String[1]\: \n>)

1: has_nlb(aka has_nlb) [0x35d5287022d1 <undefined>:5970] [bytecode=0x19def004ac9 offset=15](this=0x35d5287022d1 <undefined>)
2: prepend_comments [0x35d5287022d1 <undefined>:~5974] [pc=0x1db0ba20eeff](this=0x1ffac9b3bdb1 <Object map = 0x33ffdfdda6d1>,node=0x8bac9a49e01...
anomaliyao commented 5 years ago

+1

simpleuser99 commented 5 years ago

Hi all ! Sorry for such a long silence. We are quite busy on something that you could find useful when it is ready ! The release frequency of Elastic is hard to follow for us. Happy to hear that you patched that one successfully @pchakour . We will take a closer look in order to merge it.

When are you planning to release a plugin for kibana 6.5.x ?

denemexuser commented 5 years ago

Hi simpleuser99, Could you please share your sweet.zip file ? Thanks

qakart commented 5 years ago

I am looking for Kibana 6.5.1 is there anything I can give helping hand to get it done

lfroment-datasweet commented 5 years ago

Hi all! Happy new year to everyone! We are a small team and pretty busy on other projects right now. Following the latest version of Kibana is very tricky for us. We use 6.2 and lower for our clients. 6.5 implies too much breaking changes, we have no time for it yet. @pchakour provides a patch for 6.5.

That is the best we can do know. Sorry folks, but we promise we will make it better in the next few months, with a brand new "gizmo" for you to take advantage of your ES clusters ;-) .

SpecterHi commented 5 years ago

@pchakour @sincorecom Thanks for your great job! I wonder if it can be used it Kibana 6.5.4 since the official docker version is 6.5.4 and no 6.5.1

And Could you please release the distributable archive of the plugin? I've tried to follow the development steps but failed...

Thanks!

pchakour commented 5 years ago

I made a new patch which is working with kibana 6.5.4 and fix some issues like hidden metrics : patch_datasweet-formula-migration-6.5.zip

To use it:

SpecterHi commented 5 years ago

@pchakour Thank you! I will try again!

SpecterHi commented 5 years ago

@pchakour I followed the official guide, then apply your patch. Since npm doesn't support the type "LINK", I used yarn instead.

Then I copy the whole folder to my kibana6.5.4 docker container, restarted it Kibana started, and I saw "Datasweet Formula" in the Visualization.

But it doesn't calculate correctly... image

pchakour commented 5 years ago

I think it's an issue with the percentile metric. Use an other one and test again. I will try to fix this later.

SpecterHi commented 5 years ago

I think it's an issue with the percentile metric. Use an other one and test again. I will try to fix this later.

You are right! I just tried Max and Min, and it works! Thank you so much!

lfroment-datasweet commented 5 years ago

Hi Guys, we wanted to ask for some help if any of you wants to dive into that 6.5 / 6.6 support issue. We have no time available to do it in the near future, but we know that many are waiting for it.

Is anyone willing to help us?

toog commented 5 years ago

We are on the same team pchakour and me. The patch he made is nice for elk 6.5.4 except an issue we discover when we use hidden metric. I planned to make a PR for that. So i think you can merge his patch to release.

charlotth commented 5 years ago

Hi, please give it a try to the last release (support for kibana v6.5.x to 6.7.x). Regards