datasweet / kibana-datasweet-formula

This Kibana plugin allows calculated metrics on any standard kibana visualizations.
Apache License 2.0
121 stars 34 forks source link

Kibana 7.2.0 #52

Open lucasapaixao opened 5 years ago

lucasapaixao commented 5 years ago

To use the plugin in Kibana 7.2.0 i modify the package.json and it was possible to use the plugin. But now i have a problem with Metric visualization, when i "Hide Aggregation" Kibana produces a error. The Datasweet formula is simples: agg1/agg2 The Kibana error: "Version: 7.2.0 Build: 24337 Error: Uncaught TypeError: Cannot read property 'name' of undefined (http://kibana.unimedva.com.br/built_assets/dlls/vendors.bundle.dll.js:98) at window.onerror (http://kibana.unimedva.com.br/bundles/commons.bundle.js:3:1643907)"

karthichana commented 5 years ago

I'm having the same issue when I tried to 'Hide Aggregation' under Kibana 7.1.1.

lfroment-datasweet commented 5 years ago

Hi all, 7.2 is not supported yet. under 7.1.1 OSS, bug cannot be reproduced. Everything is working fine. @karthichana , what version are you using, and what other plugins have you installed? 711_oss_hide_no_bug

karthichana commented 5 years ago

@lfroment-datasweet it's 7.11 and you refer to the error message triggered when i tried to do the hiding.

image

tonykoval commented 5 years ago

Here is list of API changes in 7.2, https://www.elastic.co/blog/kibana-plugin-api-changes-in-7-2

tonykoval commented 5 years ago

7.3, https://www.elastic.co/blog/kibana-plugin-api-changes-in-7.3

joshkleven09 commented 5 years ago

@lfroment-datasweet I am seeing this same issue as well when using Kibana v7.1.1. Hiding the aggregation works fine in Data Table visualizations (like your example) but I get the same error posted above when trying to hide an aggregation in a Metric visualization.

karthichana commented 5 years ago

@joshkleven09 Yes you are right, it's ok with the Data Table visualizations but it doesnt work in the Metric visualization.

lfroment-datasweet commented 5 years ago

Hi, got it. Indeed, we have the same issue with OSS version. We have to investigate. It may take some time beacause we are pretty busy + vacations. Best regards to you all!

guanghaofan commented 5 years ago

@lfroment-datasweet I think it needs some time to fix the issues in v7.1.x and the other upstream versions due to the big changes in the aggconfig API. and we really hope that the new version can be released soon. You guys did grate job! thank you!