search

datatagsuite / schema

DATS JSON schemas
https://datatagsuite.github.io/docs/html/dats.html
Other
11 stars 8 forks source link

Changing Material.bearerOfDisease from null to no #19

Closed agbeltran closed 6 years ago

agbeltran commented 6 years ago

As requested by @kabolude

agbeltran commented 6 years ago

Issue with the new representation where we include an array of pairs (diseaseStatus, disease) is that it is not background compatible with previous DATS versions. But it seems the neater way of representing what we need.

agbeltran commented 6 years ago

An alternative for diseaseStatus would be to have an annotation property (so that people can tag with the ontology terms) rather than having an enum with yes/no/unknown.

agbeltran commented 6 years ago

An alternative solution that would keep the schemas background compatible would be to add the diseaseStatus to the disease_schema (and this makes more sense).

agbeltran commented 6 years ago

Closing this PR as we will use the alternative solution in #22