search

datatagsuite / schema

DATS JSON schemas
https://datatagsuite.github.io/docs/html/dats.html
Other
11 stars 8 forks source link

The schema for relatedEntities is missing #27

Closed aegururaj closed 5 years ago

aegururaj commented 5 years ago

This would possibly be the molecular entity schema?

agbeltran commented 5 years ago

@aegururaj I imagine you are referring that the different types of relatedEntities are missing from the visualisation of the schema as per this link:

https://fairsharing.github.io/JSONSchema-documenter/index.html?parameters=%7B%22target%22:%22https://w3id.org/dats/schema/molecular_entity_schema.json%22,%22display%22:%22grid%22%7D

This is not a problem of the schema but of the tool to visualise it. We will look into it.

aegururaj commented 5 years ago

How do we represent the identifiers for the relatedEntities, taxonomic information etc? Previous mapping had the following: 1) _source'.'orthology'[].'confidence' - Dataset.isAbout.MolecularEntity.relatedEntities.characteristics.Dimension.values 2) _source'.'orthology'[].'gene1AgrPrimaryId' -Dataset.isAbout.MolecularEntity.relatedEntities.Identifiers.identifier 3) _source'.'orthology'[].'gene1Species' - Dataset.isAbout.MolecularEntity.relatedEntities.taxonomy.TaxonomicInformation.identifier 4) _source'.'orthology'[].'gene1SpeciesName' - Dataset.isAbout.MolecularEntity.relatedEntities.taxonomy.TaxonomicInformation.name 5) _source'.'orthology'[*].'gene1Symbol' - Dataset.isAbout.MolecularEntity.relatedEntities.AlternateIdentifiers.identifier

agbeltran commented 5 years ago

What before was a specific 'MolecularEntity' now it can be any 'object' (that itself can be a 'MolecularEntity').

e.g. _source'.'orthology'[*].'confidence' - Dataset.isAbout.MolecularEntity.relatedEntities.object.characteristics.Dimension.values

where now the 'object' property points to a MolecularEntity with specific characteristics .

aegururaj commented 5 years ago

I assumed so but wanted to confirm. Thanks for the clarification, Alejandra ☺

From: Alejandra Gonzalez-Beltran notifications@github.com Reply-To: datatagsuite/schema reply@reply.github.com Date: Wednesday, September 19, 2018 at 9:32 AM To: datatagsuite/schema schema@noreply.github.com Cc: "Gururaj, Anupama" Anupama.E.Gururaj@uth.tmc.edu, Mention mention@noreply.github.com Subject: Re: [datatagsuite/schema] The schema for relatedEntities is missing (#27)

What before was a specific 'MolecularEntity' now it can be any 'object' (that itself can be a 'MolecularEntity'.

e.g. _source'.'orthology'[*].'confidence' - Dataset.isAbout.MolecularEntity.relatedEntities.object.characteristics.Dimension.values

where now the 'object' property points to a MolecularEntity with specific characteristics .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_datatagsuite_schema_issues_27-23issuecomment-2D422804876&d=DwMFaQ&c=6vgNTiRn9_pqCD9hKx9JgXN1VapJQ8JVoF8oWH1AgfQ&r=d5w4WGsMSBN5okxuESTpnEMKGxfgm8DFlqtMmXNdF8c&m=YpAjjKlxtRMRxTVZiXmr38Dbe-VqADfPW84iCV9y-nc&s=e1nchy82aGp_JmfKT6G_zbjR_o2vO-pOQlJIn3uF6nQ&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ALO1Fo9tmXGcgf9-5F0zdzaauY60VHrkgCks5uckd5gaJpZM4WvQWl&d=DwMFaQ&c=6vgNTiRn9_pqCD9hKx9JgXN1VapJQ8JVoF8oWH1AgfQ&r=d5w4WGsMSBN5okxuESTpnEMKGxfgm8DFlqtMmXNdF8c&m=YpAjjKlxtRMRxTVZiXmr38Dbe-VqADfPW84iCV9y-nc&s=qLUCxrWXD5HezMy6l4pT2Aq-S9PzBeEEyNm9roWto2c&e=.

agbeltran commented 5 years ago

I created the visualization issue in the json-schema documenter repo: https://github.com/FAIRsharing/JSONSchema-documenter/issues/34