PullRequest for disabling pinning subdomains

datatheorem / TrustKit-Android

Easy SSL pinning validation and reporting for Android.

MIT License

584 stars 87 forks source link

PullRequest for disabling pinning subdomains #10

Closed jobot0 closed 7 years ago

jobot0 commented 7 years ago

As mentionned by @omerlh in #8 the Android framework in N skip subdomains when the developer is specifying an empty in a nested . TrustKit Android provides a enforcePinning parameter for the config and should not let the developer uses both at the same time. We should also differentiate the missing backup pin error and this one, because it could hide it behind our current check.

omerlh commented 7 years ago

Thank you for the improvement! I am closing the original PR

jobot0 commented 7 years ago

Sure and thank you for your contributions!