extract pinning validation logic to class

datatheorem / TrustKit-Android

Easy SSL pinning validation and reporting for Android.

MIT License

584 stars 87 forks source link

extract pinning validation logic to class #11

Closed omerlh closed 5 years ago

omerlh commented 7 years ago

This should solve #6 - it will allow me to use only the pinning logic in the interceptor, without the complexity of calling to TrustManager api.

omerlh commented 7 years ago

I also added the support for Android N api. This will allow me:

Below Android N: Use interceptor and call PinningValidator
Android N and Above: Use the trust manager without passing the host name to it.

jobot0 commented 7 years ago

Thank you @omerlh we've looked to the PR and we're talking what is the cleanest way to integrate it.

omerlh commented 7 years ago

Ok, I will be happy to help if needed.

omerlh commented 7 years ago

@nehalshah50 Thank you, I missed that. Now it is fixed.

vmfo22 commented 7 years ago

@omerlh in the Android N, using the trust manager, is it work also for WebViews?

omerlh commented 7 years ago

@vmfo22 on Android N, as far as I know, the OS will do the validation for you. I am not sure how it affects webview, but it should be easy to check that.