search

datatheorem / TrustKit-Android

Easy SSL pinning validation and reporting for Android.
MIT License
588 stars 87 forks source link

Integration with React Native is broken #26

Closed omerlh closed 6 years ago

omerlh commented 6 years ago

RN API was changed from version 43 (see this commit). Since this change, there is no way to change the HTTP client used by RN to perform network request. This PR should fix it. This issue is mainly for documentation purpose, in case someone else will encounter this. Thanks @AvivRubys for finding this.

nabla-c0d3 commented 6 years ago

Thanks for letting us know! It sounds like there's not much to do on our side but wait for React Native to re-add the ability to customize the HTTP client?

omerlh commented 6 years ago

Yep, opened the issue mainly for documentation.

tasarsu commented 6 years ago

hi @omerlh did you find a certain solution for react native android ssl pinning?

There is another pr which has been closed https://github.com/facebook/react-native/pull/17237

omerlh commented 6 years ago

I think I might be missing something, but look like the original PR was closed without merging, and the PR it referred to is also closed...

nabla-c0d3 commented 6 years ago

It looks like the change was reverted back, as stated in this article: https://medium.com/@jaedmuva/react-native-ssl-pinning-is-back-e317e6682642

omerlh commented 6 years ago

This is great news! I'll try that and update..