search

datatheorem / TrustKit-Android

Easy SSL pinning validation and reporting for Android.
MIT License
583 stars 87 forks source link

TrustKit-Android can’t support multi <domain> under the same <domain-config> #78

Open BramYeh opened 3 years ago

BramYeh commented 3 years ago

Is your feature request related to a problem? Please describe. TrustKit-Android can’t support multi under the same This means it only deploys SSL public key pinning at the last domain, for example

<domain-config>
  <domain includeSubdomains="true">google.com</domain>
  <domain includeSubdomains="true">yahoo.com</domain>
  <domain includeSubdomains="true">verizon.com</domain>
<pin-set>
    <pin digest="SHA-256">AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=</pin>
    <pin digest="SHA-256">YLh1dUR9y6Kja30RrAn7JKnbQG/uEtLMkBgFF2Fuihg=</pin>
  </pin-set>
</domain-config>

TrustKit only verifies the domain verizon.com’s certificate chain. Neither google.com nor yahoo.com

Describe the solution you'd like Because TrustKit Android works by extending the Android N Network Security Configuration, it is good to support multi under the same

Describe alternatives you've considered If we want to enable SSL pinning to multi domain, even the same certificate chain, we need to separate the domain-config

<domain-config>
  <domain includeSubdomains="true">google.com</domain>
  <pin-set>
    <pin digest="SHA-256">AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=</pin>
    <pin digest="SHA-256">YLh1dUR9y6Kja30RrAn7JKnbQG/uEtLMkBgFF2Fuihg=</pin>
  </pin-set>
</domain-config>
<domain-config>
  <domain includeSubdomains="true">yahoo.com</domain>
  <pin-set>
    <pin digest="SHA-256">AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=</pin>
    <pin digest="SHA-256">YLh1dUR9y6Kja30RrAn7JKnbQG/uEtLMkBgFF2Fuihg=</pin>
  </pin-set>
</domain-config>
<domain-config>
  <domain includeSubdomains="true">verizon.com</domain>
  <pin-set>
    <pin digest="SHA-256">AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=</pin>
    <pin digest="SHA-256">YLh1dUR9y6Kja30RrAn7JKnbQG/uEtLMkBgFF2Fuihg=</pin>
  </pin-set>
</domain-config>

Additional context We can refer its test cases: https://github.com/datatheorem/TrustKit-Android/blob/master/trustkit/src/androidTest/res/xml/network_security_config.xml