Update to recommended settings in Xcode 12

datatheorem / TrustKit

Easy SSL pinning validation and reporting for iOS, macOS, tvOS and watchOS.

MIT License

2.01k stars 362 forks source link

Update to recommended settings in Xcode 12 #244

Closed sgrgrsn closed 3 years ago

sgrgrsn commented 3 years ago

I have updated the project settings to the new recommended settings in Xcode 12.

Xcode recommends enabling the CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES to get warnings if headers are imported with quotes in the framework headers.

This will also remove the warnings in projects using TrustKit.

Please let me know if I need to do anything else to get it merged.

Thanks.

sgrgrsn commented 3 years ago

I'm not sure if my changes have caused the Bitrise build to fail. It gives me this:

▸ Compiling TSKReporterTests.m

❌  /Users/vagrant/git/TrustKitTests/TSKReporterTests.m:23:9: could not build module 'OCMock'
#import <OCMock/OCMock.h>
        ^~~~~~~~~~~~~~~~

nabla-c0d3 commented 3 years ago

Thanks - I ended up updating the settings as part of something else I was doing.