Fix crash when cache persisting fails

datatheorem / TrustKit

Easy SSL pinning validation and reporting for iOS, macOS, tvOS and watchOS.

MIT License

2.01k stars 362 forks source link

Fix crash when cache persisting fails #268

Closed tadija closed 2 years ago

tadija commented 2 years ago

Removed excessive NSAssert in order to fix #261

mflint commented 2 years ago

Thank-you @tadija!

@datatheorem It’d be wonderful to get this merged, or find a way to reliably store the cache.

nabla-c0d3 commented 2 years ago

Thanks for the proposal. I ended up merging https://github.com/datatheorem/TrustKit/pull/272 instead which provides a slightly better fix. In general, NSAssert() should not trigger a crash in a production build.

mflint commented 2 years ago

Doh, of course, you’re right that #272 is the correct solution. Thank-you @nabla-c0d3 !

(Will this change be in a release?)