search

datatlas-erasme / back

[DEPRECATED] Back-office for DATATLAS project
https://github.com/datatlas-erasme/datatlas
GNU Affero General Public License v3.0
0 stars 0 forks source link

Tests shouldn't depends on a global lib, `mocha` should be part of the `devDependencies`. #3

Closed lutangar closed 1 year ago

lutangar commented 2 years ago

Tests shouldn't depends on a global lib, mocha should be part of the devDependencies.

_Originally posted by @lutangar in https://github.com/datatlas-erasme/back/pull/2#discussion_r941421278_

racine-p-a commented 2 years ago

@lutangar Should be done. Am I missing something on this issue ? https://github.com/datatlas-erasme/back/commit/0499e4eb62666bcf0334a795e7a0aaf33acc3038

Pipazoul commented 2 years ago

Updated the readme https://github.com/datatlas-erasme/back/pull/7

Pipazoul commented 2 years ago

@lutangar @racine-p-a can we close this issue ?

lutangar commented 2 years ago

This is still an issue, last commits aaf70efb6d5353ec3594222636cec4041b8b9bdc and 403841f15b6dd42ff35ef5f17a7a9b74419f23a7 aren't on dev branch.

Here's my suggestion for the "testing" part of the doc : https://pad.georgette.party/wTiB8H8PSaydeI0vWQ391A?both

Feel free to disagree and adapt !