datatogether / archivertools

Python package for scraping websites into the Data Together pipeline via morph.io
GNU Affero General Public License v3.0
6 stars 1 forks source link

Specify testing conventions and create a reference example test class in the testing file #20

Open jeffreyliu opened 6 years ago

jeffreyliu commented 6 years ago

Specify in README and/or CONTRIBUTING the conventions that tests should follow and create an example test class within tests.py for reference that specifies and implements the conventions.

To get us started: Conventions:

I'd welcome any feedback about any additions/changes to conventions, and also thoughts about where it should live, esp @weatherpattern @ebenp

python unittest library docs for reference: python3: https://docs.python.org/3/library/unittest.html python2: https://docs.python.org/2/library/unittest.html

dcwalk commented 6 years ago

Could we describe this issue a little more fully @jeffreyliu ? I'm not entirely sure what the ask is (aka -- what does the default template have to require on a first iteration)

jeffreyliu commented 6 years ago

yup! I'll update the top level comment with the details. I unfortunately didn't get around to fleshing out the ask when I made it.