search

datatogether / webapp

Web application to allow users to add content metadata about crawled resources
https://archivers.co/
GNU Affero General Public License v3.0
13 stars 12 forks source link

Communities #38

Closed b5 closed 7 years ago

b5 commented 7 years ago

This PR closes out part 1 of this roadmap item

I'm going to keep improving / refining, but the rough bits are in place for merging anytime.

b5 commented 7 years ago

Ok, so there's a 50/50 chance you'll be able to give this a try locally now 😉 Instructions:

  1. Make sure you have docker and docker-compose.
  2. Clone this repo, cd into the top dir.
  3. git fetch
  4. git checkout communities
  5. docker-compose up. wait a long time, console will settle down.
  6. browser -> localhost:3000/login. username: jeffliu, password: password
  7. see if you can hit "archive" on the "All of the puppies" collection.

There are so. many. bugs. said bugs can & will be fixed. I'd like this to be considered mergeable if someone else can get the above to work.

flyingzumwalt commented 7 years ago

same as @machawk1. got it to work. after hitting "archive" I had to reload the page in order to see the ipfs hashes.

FYI: the "archive" link didn't appear at first but I restarted docker and then it appeared. not sure what was wrong. I had previously loaded a different branch of the code, so might be that.

flyingzumwalt commented 7 years ago

should we merge this and then fix bugs iteratively in separate PRs?

b5 commented 7 years ago

I mean, this convo has images of puppies. Isn't this grounds for merging?

flyingzumwalt commented 7 years ago

I think it's a level up from what's in master. Better to get that in master and then move forward from there. I will merge.

b5 commented 7 years ago

but yes, I vote we merge & file lots of issues for existing bugs. I think increased participation in the design/dev process is more important than clean code at this point, and we can rapidly iterate on improvements.

machawk1 commented 7 years ago

@b5 I want to add that I did not see the Archive link on the initial load as well (like @flyingzumwalt). I navigated away, back to the puppies collection then saw the Archive link. I hit the link, navigated away and navigated back, and only THEN saw the hashes. All seemed right on repeated docker-up, the hashes persisted.