datatogether / webapp

Web application to allow users to add content metadata about crawled resources
https://archivers.co/
GNU Affero General Public License v3.0
13 stars 12 forks source link

Document & Organize React Components as separate package #44

Open b5 opened 7 years ago

b5 commented 7 years ago

With the EDGI web-monitoring project moving away from typescript, and @Blackglade working on react visualization components, we have more reasons to build out our components as a standalone library. Getting these components used in multiple places gets more eyes, and forces us to maintain a cleaner codebase.

If others are interested, I'd be happy to put the time into building this library from our existing parts, mainly b/c I don't think it would take too long, and would be time well spent.

If we built this, @lightandluck, @danielballan, @Mr0grog, do you think there's a chance it'll get used in web-monitoring?

Mr0grog commented 7 years ago

I think we already have one component in common (List), though it looks like it has since evolved slightly differently (but likely no problem to re-unify), so yes, this would be useful at some level. We should probably try and keep it to more generic things or maybe only promote components/utilities to it as we find ones worth sharing (e.g. we certainly wouldn’t want to merge Navbar classes).