search

datatogether / website

A static-generated website to introduce the Data Together project, built with Hugo.
http://datatogether.org
9 stars 5 forks source link

fix mobile css & content-ize homepage #12

Closed b5 closed 7 years ago

b5 commented 7 years ago

This should be mergeable. It closes #9 and #8 (ok, it barely closes #8, but we'll improve some more once we have an aesthetic revisit)

dcwalk commented 7 years ago

@mhucka -- I think we want to seperate proofreading comments into broader vision/website language rather than this PR?

This is for addressing mobile & location of there the copy is located.

Are you okay if we move your insights to an issue to be incorporated with other language updates?

mhucka commented 7 years ago

@dcwalk Ah, yeah, sorry, I guess I missed the fact that this about mobile & location. Absolutely fine to move it to a different issue.

dcwalk commented 7 years ago

@mhucka -- Thanks! I've moved 'em to #14

dcwalk commented 7 years ago

ping @b5 for thoughts on youtube video column

b5 commented 7 years ago

Yeah the youtube thing is bad. I removed the width param from the iframe to get the video to scale down on mobile (otherwise it just flows off the screen). I'm sure there's a proper way to approach scaling youtube iframes, just haven't had the chance to look it up.

dcwalk commented 7 years ago

Okay, I'm going add out as an issue and merge this in now, as we are letting small fixes linger to long in review