datatonic / duke

Automatically exported from code.google.com/p/duke
0 stars 0 forks source link

Add lines to test-file #76

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Start matching using the --testfile and --testdebug as a option. The 
testfile should be empty.

All records will be listed as "Unknown links found".

SUGGESTION:
There should be an option for the user to be prompted for including records not 
found in testfile as a match or not a match.

Original issue reported on code.google.com by Erlend.B...@gmail.com on 30 May 2012 at 8:41

GoogleCodeExporter commented 8 years ago
The test file is what tells Duke which matches are correct and incorrect, so if 
it's empty Duke will indeed say all links are unknown (because they're not in 
the test file).

If you want Duke to write the links it finds into a test file, you can do that 
with --linkfile=<filename>. If a test file is specified Duke will ignore those 
links already in the test file.

If you want Duke to prompt you to verify the links as they are written, you can 
add --interactive. 

Does this help?

Original comment by lar...@gmail.com on 30 May 2012 at 8:49

GoogleCodeExporter commented 8 years ago
This does not seem to function as described. I get prompted, as described for 
some of the records, but they are not entered into the test file. When 
repeating the test I am prompted for the same records as I in the previous run 
specified as matching records. 

Original comment by Erlend.B...@gmail.com on 30 May 2012 at 9:09

GoogleCodeExporter commented 8 years ago
That's right. They're entered into the link file. Basically, the test file is 
input, and the link file is output. Duke never changes the test file.

I guess I may need to document this better.

Original comment by lar...@gmail.com on 30 May 2012 at 9:14

GoogleCodeExporter commented 8 years ago
What do you think of the suggested feature? I believe it would reduce the 
amount of manual work needed to generate the test file.

Original comment by Erlend.B...@gmail.com on 30 May 2012 at 9:22

GoogleCodeExporter commented 8 years ago
Well, I don't completely understand what you ask for, but as far as I can tell, 
the feature is already there. Try running

...Duke --linkfie=linkfile.txt --interactive <config-file>

and look at linkfile.txt afterwards.

Original comment by lar...@gmail.com on 30 May 2012 at 9:28

GoogleCodeExporter commented 8 years ago
What I suggest is that records not found in the test file are optionally 
entered into the test file, after prompting the user, by Duke. 

I see this as a useful feature when tuning the configuration file. When I 
started to tune the configuration I initially had a very limited number of 
records, and thus the number of record in the test file was also limited. 
However when I wanted to include more records (in order to fine tune the 
configuration file) the task of adding records to the test file quickly became 
large.

Original comment by Erlend.B...@gmail.com on 30 May 2012 at 9:46

GoogleCodeExporter commented 8 years ago
Can't you just run with the linkfile option, then do "cat linkfile.txt >> 
testfile.txt"? Or something similar?

I'm not saying I'm against your idea. I'm just trying to check that you 
understand what's already there, and trying to understand why you prefer it 
this way.

I understand your use case. It's the same one I developed this functionality 
for.

Original comment by lar...@gmail.com on 30 May 2012 at 10:03

GoogleCodeExporter commented 8 years ago
Now I see what you mean, and that the feature I am asking for is already 
implemented. Thank you.

Original comment by Erlend.B...@gmail.com on 30 May 2012 at 10:31

GoogleCodeExporter commented 8 years ago
Good! :-)

Original comment by lar...@gmail.com on 30 May 2012 at 10:36