Closed howardbaek closed 1 week ago
No broken urls! :tada: Comment updated at 2024-02-15 with changes from 276e4fb424b5a37be085e34e3eacffcdf027348b
No spelling errors! :tada: Comment updated at 2024-07-09-18:11:36 with changes from 0d537dcfdc9e0b01037abf8f34c04099187969f5
This looks great! I've left a few specific comments inline. A few additional questions:
- I couldn't see the two png files being referenced in the markdown. Should they be removed?
- Maybe we can expand on the reason for using Python or when to stick with R?
NOTE to myself
To convert .Rmd to .md:
Get rid of the curly brackets around the python. Delete the R from .Rmd to make it a .md file Delete all knitr code chunks Replace the ottrpal image part with Till's syntax for including images.
To render locally: make "name_of_document" .ipynb.html
@tillahoffmann I've made more changes to 03-intro-to-python.md
and committed that file. However, I'm not sure where these files came from:
.ipynb_checkpoints/03-intro-to-python-checkpoint.md
docs/03-intro-to-python.md
02-chapter_of_course_files/figure-html/unnamed-chunk-2-1.png
02-chapter_of_course_files/figure-html/unnamed-chunk-3-1.png
Is it safe to delete these files?
.ipynb_checkpoints
directory and add it to the .gitignore
.python.Rproj
and add *.Rproj
to the .gitignore
.docs/03-intro-to-python.md
, I'm not sure how that was created. Maybe @cansavvy has an idea?_bookdown_files
, I'll also defer to @cansavvy.
- Let's delete the
.ipynb_checkpoints
directory and add it to the.gitignore
.- Let's delete the
python.Rproj
and add*.Rproj
to the.gitignore
.- Regarding the
docs/03-intro-to-python.md
, I'm not sure how that was created. Maybe @cansavvy has an idea?- Regarding the
_bookdown_files
, I'll also defer to @cansavvy.
No broken url errors! :tada: Comment updated at 2024-07-09-18:10:33 with changes from bab84da18bea82025a99cf1d1393d7f0c4345514
Following changes have been made:
.ipynb_checkpoints/
and add it to the .gitignore
python.Rproj
and add to .gitignore
Re-rendered previews from the latest commit:
Updated at 2024-07-09 with changes from 0d537dcfdc9e0b01037abf8f34c04099187969f5
Purpose/implementation Section
What changes are being implemented in this Pull Request?
First draft of the "Intro to Python" chapter.
What was your approach?
I start with an introduction to Python, then touch on the main differences between R and Python, then talk about the major differences in Python for R users, which are mainly drawn from Primer on Python for R Users. Importantly, I briefly talk about OOP and classes, giving a small code snippet of a class in Python.
What GitHub issue does your pull request address?
This PR addresses https://github.com/datatrail-jhu/python/issues/2
Tell potential reviewers what kind of feedback you are soliciting.
Open to any feedback or comments!
New Content Checklist
[ ] New content/chapter is in an Rmd file with this kind of format and headers.
[ ] New content/chapter contains Learning Objectives and are in the correct format.
[ ] Bookdown successfully re-renders and any new content files have been added to the _bookdown.yml.
[ ] Spell check runs successfully in Github actions style-n-check).
[ ] Any newly necessary packages that are needed have been added to the Dockerfile and image.
[ ] Images are in the correct format for rendering.
[ ] Every new image has alt text and is in a Google Slide.
[ ] Each slide is described in the notes of the slide so learners relying on a screen reader can access the content. See https://lastcallmedia.com/blog/accessible-comics for more guidance on this.
[ ] The color palette choices of the slide are contrasted in a way that is friendly to those with color vision deficiencies. You can check this using Color Oracle.