feat: enable PathLocationStrategy

datatypevoid / vulgar

A simple and scalable MEAN stack development kit featuring Angular 2 (Router, Http, Forms, Services, Tests, E2E, Coverage, Dev/Prod), Express, MongoDB, Mongoose, Node, PassportJS, Socket.io, Karma, Protractor, Jasmine, Istanbul, SASS Support, TypeScript, TSLint, NG2Lint, Hot Module Replacement, Docco, Gulp, and Webpack by @datatypevoid

MIT License

286 stars 66 forks source link

feat: enable PathLocationStrategy #9

Closed b3kN closed 8 years ago

b3kN commented 8 years ago

Feature to enable PathLocationStrategy

Currently a hash sign will always be in the URL as default
New feature removes hash sign from URL

datatypevoid commented 8 years ago

Will this mesh alright with the fact that we are using the deprecated beta router in the pack right now? Also, wouldn't it be better to house this addition in src/platform/providers.ts?

b3kN commented 8 years ago

I think it should mesh fine as it is really just changing the LocationStrategy within the router, regardless of the fact we use the deprecated router.

I didn't see the providers.ts until after this PR, I have an updated branch using that file instead of hacking into the bootstrap.

b3kN commented 8 years ago

After seeing the APPLICATION_PROVIDERS constant, I don't think this PR is necessary. It is nice to see how easy it is to modify the LocationStrategy though.

datatypevoid commented 8 years ago

Yeah, I think I am going to merge it anyway, I prefer my URLs without the hash signs.

b3kN commented 8 years ago

Up to you if you want it in or not, but I added a configuration options for allowing the user to configure the LocationStrategy they prefer. A little more "Hacky" than I would like however...

datatypevoid commented 8 years ago

I think I will just default to PathLocationStrategy in the pack and not even give notice to HashLocationStrategy