datavane / datavines

Know your data better!Datavines is Next-gen Data Observability Platform, support metadata manage and data quality.
https://datavane.github.io/datavines-website/
Apache License 2.0
510 stars 157 forks source link

[Bug] [Metrics] Check result is wrong in formula 'Actual/Expected*100%' when left side value contains decimals #437

Closed leeoo closed 2 months ago

leeoo commented 2 months ago

Search before asking

What happened

规则作业检查结果的校验公式那里,会对小数进行四舍五入到整数,比如这个公式左边算出来应该是 76.54,76.54 >= 77.0 公式不成立,结果应该是失败的,但由于四舍五入了,变成了 77.0 就相等了,检查结果就变成功了。 3ddae6a70bcab255bff5bbc67fec550

DataVines Version

branch: dev version: 1.0.0-SNAPSHOT

DataVines Config

See detail in 'What happend'.

Running Command

See detail in 'What happend'.

Error Exception

No exception, just wrong check result.

Engine Type

local

Java Version

11

Screenshots

No response

Are you willing to submit PR?

zixi0825 commented 2 months ago

this issue has been fixed in #434

leeoo commented 2 months ago

I can still reproduce this issue after running the latest dev code. 1724636638617 图片