search

dataviruset / sm-hosties

The ultimate jailbreak plugin for SourceMod
https://forums.alliedmods.net/forumdisplay.php?f=155
GNU General Public License v3.0
29 stars 27 forks source link

Use ClientCommand for First/Third Person in csgo #20

Closed ghost closed 8 years ago

data-bomb commented 8 years ago

How does this method work? Aren't these cheat commands?

ghost commented 8 years ago

Yes, but it works fine with ClientCommand.

data-bomb commented 8 years ago

I'm worried this is not so efficient with OnPreThink. What about if we start/stop the SDKHook only when we need it? e.g., when the SetFirstPerson/SetThirdPerson are called? As a consequence we would need to bring them back into the fold of lastrequest.sp and deprecate them in the lastrequest.inc

ghost commented 8 years ago

Hm, I'll take a look tomorrow or this weekend.

ghost commented 8 years ago

It will only called in ThirdPerson KnifeFight.

data-bomb commented 8 years ago

@Bara20 The SetFirstPerson/SetThirdPerson in the INC file can't be changed this way because external plugins won't be able to give the input as the game type as-written.

data-bomb commented 8 years ago

https://github.com/dataviruset/sm-hosties/commit/5b14bb008f98ec73f69eff08b786858c4e42dd18 and https://github.com/dataviruset/sm-hosties/commit/efff7c6e9014add3f1109dba065c255b8c166803 supersede this due to above comments.