dataviruset / sm-hosties

The ultimate jailbreak plugin for SourceMod
https://forums.alliedmods.net/forumdisplay.php?f=155
GNU General Public License v3.0
29 stars 27 forks source link

Bug #33

Closed Kailo97 closed 8 years ago

Kailo97 commented 8 years ago

In LastRequest_WeaponFire in hosties/lastrequest.sp

public LastRequest_WeaponFire(Handle:event, const String:name[], bool:dontBroadcast)
{
    ...
    else if (type == LR_Shot4Shot)
    {
        ...
        if (StrEqual(LR_WeaponName, FiredWeapon)) // This line
        {
            ...
        }
        ...
    {
    ...
}

In CSGO different weapons can have same class, like: revolver->deagle; usp_silencer->hkp2000. You can't play S4S using Revolver and USP-S — you will be killed after the first shot.

SHAREN commented 8 years ago

would not it be sm_hosties in conflict with this extention? https://forums.alliedmods.net/showthread.php?t=236199

data-bomb commented 8 years ago

Thanks Kailo97, I was just speaking with some of the other devs on why we're doing the string check there anyway. The M4M checks are much more efficient although we should be using EntRef translations like we do in Russian Roulette for these as well.

https://github.com/dataviruset/sm-hosties/commit/370b4302eac7f7140ef7acbcadce15064b7cb6e5 closes this.