search

dataviruset / sm-hosties

The ultimate jailbreak plugin for SourceMod
https://forums.alliedmods.net/forumdisplay.php?f=155
GNU General Public License v3.0
29 stars 27 forks source link

new native: IsLastRequestAvailable #53

Closed shanapu closed 8 years ago

shanapu commented 8 years ago

As we have already discussed, here is a new native as bool IsLastRequestAvailable. Would be usefull for MyJailbreak and certainly other plugins.

data-bomb commented 8 years ago

Looks good and thanks for sending this to beta branch. Could you change Line 858 to just be: return false; Although it's functionally equivalent, the last line should be a return for easier visibility. Also, the else on the same line as the rest deviates from the style. edit: also the extra space in 852. Is there a way I can make these changes to the PR? I'm not so advanced with GitHub knowledge yet.

shanapu commented 8 years ago

Is there a way I can make these changes to the PR? I'm not so advanced with GitHub knowledge yet.

Im also not so advanced with Git at all. To my knowledge there is no way for you to change/add commits to my pull request. As I seen on other bigger projects, they handle it like we do. You tell me your wishes for this PR and I have to change it. Other way, merge my pull request and add your own commit with changes.