data-bomb
commented
7 years ago Stock functions do not cause bloat. They are removed if they're not used. This is fairly well documented in the Pawn guides.
Not sure why plugins are just using lastrequest.inc when the examples we had used both. It wasn't correct to just include lastrequest.inc.
However, I can see why this would present a problem. The default value of Game_Unknown in SetThirdPerson was a recent addition and this would break compatibility with a plugin incorrectly including only lastrequest.inc.
If anything, the change here should be to include hosties from lastrequest.inc so the error and direction is more clearly presented.
Sent from my iPhone
On Nov 15, 2016, at 10:34, DrKittens [Masked] wrote:
Preview: Hosties.inc appears to just be stocks for sm_hosties to work. This email is forwarded from a MASKED EMAIL you created using Blur. IF THIS IS SPAM, CLICK HERE TO BLOCK.
Want to shop safely and privately online? Get Blur Premium.
Hosties.inc appears to just be stocks for sm_hosties to work. Lastrequest.inc is where the natives are and is meant to be included with other plugins. Lastrequest.inc requires this enum to compile, if its in Hosties.inc then Hosties.inc needs to be included aswell which i believe is bad practice as it creates bloat.
Some plugins will actually fail to compile using a clone of the github master as they (correctly) do not include hosties.inc, and only include lastrequest.inc. The error given will be something along the lines of undefined symbol game_unknown.
You can view, comment on, or merge this pull request online at:
https://github.com/dataviruset/sm-hosties/pull/63
Commit Summary
Move GameType enum to lastrequest.inc File Changes
M addons/sourcemod/scripting/include/hosties.inc (7) M addons/sourcemod/scripting/include/lastrequest.inc (7) Patch Links:
https://github.com/dataviruset/sm-hosties/pull/63.patch https://github.com/dataviruset/sm-hosties/pull/63.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
Bara
Hosties.inc appears to just be stocks for sm_hosties to work. Lastrequest.inc is where the natives are and is meant to be included with other plugins. Lastrequest.inc requires this enum to compile, if its in Hosties.inc then Hosties.inc needs to be included aswell which i believe is bad practice as it creates bloat.
Some plugins will actually fail to compile using a clone of the github master as they (correctly) do not include hosties.inc, and only include lastrequest.inc. The error given will be something along the lines of undefined symbol game_unknown.