dataviruset / sm-hosties

The ultimate jailbreak plugin for SourceMod
https://forums.alliedmods.net/forumdisplay.php?f=155
GNU General Public License v3.0
29 stars 27 forks source link

Fix crash with StripAllWeapons ( #73 ) #74

Closed Bara closed 7 years ago

Bara commented 7 years ago

I've added this stock to remove a weapon.

data-bomb commented 7 years ago

A few questions.. Would we want to remove the C4 or no? My preference would be to let them keep the C4 in case there are separate game mods that want them to keep it such as a suicide bomber plugin.

Have you been able to test the SafeRemoveWeapon stock on CS:S or CS:GO? I must confess I'm not sure why we need to get rid of the world model first or why this is safer. Is there a post on the history of this somewhere?

Since the SafeRemoveWeapon returns a bool, do we need to add a void when we call that stock to avoid any compiler warnings?

Bara commented 7 years ago

We could add a new cvar like "Do you want to remove c4 on ...?"

I think it's a bit safer

I had no warnings or errors.