dataviruset / sm-hosties

The ultimate jailbreak plugin for SourceMod
https://forums.alliedmods.net/forumdisplay.php?f=155
GNU General Public License v3.0
29 stars 27 forks source link

Fix a lot of old stuff #9

Closed ghost closed 9 years ago

ghost commented 9 years ago

Replaced old, unsupported and/or deprecated stuff with new stuff.

1 #2 #3 #4 #5 #6 #7

@dataviruset

DorCoMaNdO commented 9 years ago

Please revert the workaround for the USP in CS:GO, your current code is only viable for the CT side and covers only the USP while there are other weapons causing issues. I have a code I made a while ago for a private project of mine, I'll make some adjustments and submit it when I get some time to work on it.

ghost commented 9 years ago

I know, but all reported crash bugs are with this reason. So I think this enough.

dataviruset commented 9 years ago

Maybe I should've mentioned it before, but it would be great if you could split everything up into many commits, one for every feature or small adjustment, instead of having one commit for a lot of things. That way it's easier to track what changed and which code changes are connected to each other. If you think it will be too much hassle, we can accept it like this for this time, though.

ghost commented 9 years ago

@dataviruset Ok, after that.

@DorCoMaNdO btw. We can add this nowm because it's only an workaround. You can change it at any time.

dataviruset commented 9 years ago

I know that @DorCoMaNdO might disagree, but I think @Bara20's fix is good enough for now, we can always make it better later :)

ovo4096 commented 9 years ago

GetClientAuthId may not work at SM 1.5.0

ghost commented 9 years ago

And? SM1.5 and SM1.6 are unsupported. Current stable release is 1.7.2 ( https://wiki.alliedmods.net/SourceMod_1.7.2_Release_Notes ), so why support for sm1.6 and/or lower? Here is a list of supported versions: http://www.sourcemod.net/snapshots.php

ovo4096 commented 9 years ago

I see the introduction, this plugin is Requirements: SourceMod 1.5.0+.

'void' is not a Pawn type. :3

ghost commented 9 years ago

https://wiki.alliedmods.net/SourcePawn_Transitional_Syntax

I'll change the requirements.

ovo4096 commented 9 years ago

:3 I think it is better supported SM 1.5.0.

ghost commented 9 years ago

No, sourcemod 1.5 is a unsupported version (https://github.com/alliedmodders/sourcemod/tree/1.5-dev last commit 2014...) and sourcemod 1.6 (https://github.com/alliedmodders/sourcemod/tree/1.6-dev last commit february 2015...).

But that's a decision for @dataviruset

ovo4096 commented 9 years ago

Ah, You're right.

ghost commented 9 years ago

? @dataviruset