datavis-tech / graph-data-structure

A graph data structure with topological sort and shortest path algorithms.
MIT License
249 stars 46 forks source link

Default export in package.json not being last is triggering a webpack error #64

Closed cbranch101 closed 11 months ago

cbranch101 commented 1 year ago
"exports": {
    "require": "./dist/index.cjs",
    "default": "./dist/index.modern.js",
    "types": "./dist/index.d.ts"
},

webpack and node want the default the key to be last

curran commented 1 year ago

How to reproduce the error/warning?

I would welcome a PR for a fix if you'd like to take a stab at it.

flleonx commented 1 year ago

I got the same error

image

rtlastra commented 1 year ago

I got the same error

curran commented 1 year ago

Released fix in https://github.com/datavis-tech/graph-data-structure/releases/tag/v3.3.0

Please let me know if this solves the issue for you. Thanks!

rtlastra commented 1 year ago

Released fix in https://github.com/datavis-tech/graph-data-structure/releases/tag/v3.3.0

Please let me know if this solves the issue for you. Thanks!

I have already checked the issue in my local, could you please load this release in npm?

curran commented 1 year ago

Released.

curran commented 11 months ago

Closing as I think this is fixed.

Please let me know if this issue is still there in the latest, thanks!

https://github.com/datavis-tech/graph-data-structure/releases/tag/v3.4.0