Use objects internally & revise get API

datavis-tech / topologica

Minimal library for reactive dataflow programming. Based on topological sort.

MIT License

50 stars 1 forks source link

Use objects internally & revise get API #30

Closed curran closed 6 years ago

curran commented 6 years ago

Closes #27 & #28

Before:

Size: 1046 bytes
Benchmark avg: 510 ms

After:

Size: 956 bytes
Benchmark avg: 295 ms

curran commented 6 years ago

Size: 1036 bytes
Benchmark avg: 422 ms

curran commented 6 years ago

Size: 1009 bytes
Benchmark avg: 375 ms

curran commented 6 years ago

Size: 996 bytes
Benchmark avg: 366 ms

curran commented 6 years ago

Size: 977 bytes
Benchmark avg: 303 ms

curran commented 6 years ago

Size: 965 bytes
Benchmark avg: 300 ms

curran commented 6 years ago

Size: 960 bytes
Benchmark avg: 295 ms

curran commented 6 years ago

Size: 956 bytes
Benchmark avg: 295 ms

curran commented 6 years ago

May have been too aggressive here, as the objects passed into the reactive functions now contain all properties. May be best to bring back the behavior of only passing in the dependencies.

Investigated this thought in https://github.com/datavis-tech/topologica/pull/31

curran commented 6 years ago

TODO here: update the docs.