fix(ranking): promise chain for selection queue in `RankingViewComponent` - Githubissues

datavisyn / tdp_core

Target Discovery Platform Core

BSD 3-Clause "New" or "Revised" License

6 stars 2 forks source link

fix(ranking): promise chain for selection queue in `RankingViewComponent` #830

Closed dvzacharycutler closed 1 year ago

dvzacharycutler commented 1 year ago

Closes https://github.com/datavisyn/reprovisyn/issues/676

Developer Checklist (Definition of Done)

Issue

[x] All acceptance criteria from the issue are met
[x] Tested in latest Chrome/Firefox

UI/UX/Vis

[ ] Requires UI/UX/Vis review
- [ ] Reviewer(s) are notified (tag assignees)
- [ ] Review has occurred (link to notes)
- [ ] Feedback is included in this PR
- [ ] Reviewer(s) approve of concept and design

Code

[x] Branch is up-to-date with the branch to be merged with, i.e., develop
[x] Code is cleaned up and formatted
[ ] Unit tests are written (frontend/backend if applicable)
[ ] Integration tests are written (if applicable)

PR

[x] Descriptive title for this pull request is provided (will be used for release notes later)
[x] Reviewer and assignees are defined
[ ] Add type label (e.g., bug, feature) to this pull request
[ ] Add release label (e.g., release: minor) to this PR following semver
[ ] The PR is connected to the corresponding issue (via Closes #...)
[x] Summary of changes is written

Summary of changes

Small changes to typings to the selection adapter, and a few changes to the RankingViewComponent to allow us to fix the selection bug in reprovisyn. Creates a queue of promises to ensure that column adding always knows the correct columns before doing so.

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗