feat(vis): focus facet selector for bar chart - Githubissues

datavisyn / visyn_core

BSD 3-Clause "New" or "Revised" License

1 stars 1 forks source link

feat(vis): focus facet selector for bar chart #420

Closed thinkh closed 1 month ago

thinkh commented 1 month ago

Closes #419

Developer Checklist (Definition of Done)

Issue

[x] All acceptance criteria from the issue are met
[x] Tested in latest Chrome/Firefox

UI/UX/Vis

[ ] Requires UI/UX/Vis review
- [ ] Reviewer(s) are notified (tag assignees)
- [ ] Review has occurred (link to notes)
- [ ] Feedback is included in this PR
- [ ] Reviewer(s) approve of concept and design

Code

[x] Branch is up-to-date with the branch to be merged with, i.e., develop
[x] Code is cleaned up and formatted
[ ] Unit tests are written (frontend/backend if applicable)
[ ] Integration tests are written (if applicable)

PR

[x] Descriptive title for this pull request is provided (will be used for release notes later)
[x] Reviewer and assignees are defined
[x] Add type label (e.g., bug, feature) to this pull request
[x] Add release label (e.g., release: minor) to this PR following semver
[x] The PR is connected to the corresponding issue (via Closes #...)
[x] Summary of changes is written

Summary of changes

Add focus facet component to toolbar
Select focus facet on click on the title and return to overview if clicked again
Cycling infinitely through all facets in focus mode

Screenshots

bar-chart-focus-facet.webm

Additional notes for the reviewer(s)

The flag showFocusFacetSelector in the bar config is disabled by default and needs to be enabled on demand. We can decide whether or not to show it by default.

Thanks for creating this pull request 🤗

thinkh commented 1 month ago

We still need to test and add some error handling if the focus index is invalid (as for example in an old session).