datavisyn / visyn_core

BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

feat: introducing playwright tests #424

Closed dvlilialbrecht closed 1 week ago

dvlilialbrecht commented 1 month ago

Closes #409

Creating playwright tests for all visyn core plots (scatter plot, box plot, correlation plot, heat map, hexbin, violin plot). All plots have multiple test-files, with general tests (download, selection etc.) and with every setting.

Tests were created with chromatic, so all visual changes can be viewed there.

Still open issue: The Scatter plot problem. Chromatic does not show dots of WebGL plot. This is most likely a Chromatic issue, since when taking screenshots with playwright, these dots are visible. Screenshot from 2024-08-21 10-55-56

Tests were also run in the CI: Timed out waiting 600s for the test suite to run Following tests are commended out:

puehringer commented 1 week ago

@dvlilialbrecht @dvdanielamoitzi please update the build.yml and build_nightly.yml from Aevidence.

puehringer commented 1 week ago

@dvlilialbrecht @dvdanielamoitzi I updated everything to visyn_scripts 11 and removed the storybook overrides, and let the build run: https://github.com/datavisyn/visyn_core/actions/runs/10698246357/job/29657200985

One thing I noticed: all our stories are using import { ComponentStory } from '@storybook/react';, but that only exists in @storybook/react: 7, not 8. I thought chromatic installs storybook 8? Why doesn't it need @storybook/react? And now we are installing version 7 of @storybook/react, and 8 of storybook via chromatic? Sounds like a problem to me, so maybe we should go ahead and upgrade the stories to 8 as well? Let me know what you think.

EDIT: I just downgraded everything to storybook 7, let's see if things are still working: https://github.com/datavisyn/visyn_core/actions/runs/10698512709