fix: add null check for the user - Githubissues

datavisyn / visyn_core

BSD 3-Clause "New" or "Revised" License

1 stars 1 forks source link

fix: add null check for the user #474

Closed dv-usama-ansari closed 1 month ago

dv-usama-ansari commented 1 month ago

Closes #473

Developer Checklist (Definition of Done)

Issue

[ ] All acceptance criteria from the issue are met
[x] Tested in latest Chrome/Firefox

UI/UX/Vis

[x] Requires UI/UX/Vis review
- [x] Reviewer(s) are notified @puehringer @thinkh
- [ ] Review has occurred (link to notes)
- [ ] Feedback is included in this PR
- [ ] Reviewer(s) approve of concept and design

Code

[x] Branch is up-to-date with the branch to be merged with, i.e., develop
[x] Code is cleaned up and formatted
[ ] Unit tests are written (frontend/backend if applicable)
[ ] Integration tests are written (if applicable)

PR

[x] Descriptive title for this pull request is provided (will be used for release notes later)
[x] Reviewer and assignees are defined
[x] Add type label (e.g., bug, feature) to this pull request
[x] Add release label (e.g., release: minor) to this PR following semver
[x] The PR is connected to the corresponding issue (via Closes #...)
[x] Summary of changes is written

Summary of changes

Add null check before displaying the user menu

Screenshots

N/A

Additional notes for the reviewer(s)

N/A

puehringer commented 1 month ago

@dv-usama-ansari @thinkh Why don't we add the check where we use it (so the interface remains correct, i.e. not null): https://github.com/datavisyn/visyn_core/blob/d917ce2e19144a074f554d0f4871d6af8a636c2c/src/app/header/VisynHeader.tsx#L98

I.e. just check user && user.name and render the menu?

thinkh commented 1 month ago

@puehringer Good suggestion. Let's keep things simple and do it like this. 👍