Better vis config merge - Githubissues

datavisyn / visyn_core

BSD 3-Clause "New" or "Revised" License

1 stars 1 forks source link

Better vis config merge #498

Closed dvmartinweigl closed 1 week ago

dvmartinweigl commented 2 weeks ago

The way we merge vis configs in the EagerVis is quite hacky. In order to simplify things we should:

get rid of useUncontrolled and always just have one visCofing/setVisConfig that must be passed
get rid of useEffect for config merge (see: https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes:~:text=directly%20during%20rendering%3A-,function%20List(%7B%20items%20%7D)%20%7B,//%20...,-%7D)
ensure config merge for each vis type