datawagovau / ckanext-datawagovautheme

CKAN customisations and theme for data.wa.gov.au
7 stars 8 forks source link

[Dataset List] Modal dialogs don't display a close icon #29

Open keithmoss opened 5 years ago

keithmoss commented 5 years ago

https://uat.landgate.links.com.au/dataset

Responsive design issue on mobile devices.

For example, the "Filter results" modal dialog doesn't display any close icon in the top right hand corner. There's still a UI element there and you can click it, just no icon to show that there's something to click.

Suggestion: Change the <i class="icon-remove-sign"> icon class to <i class="fa fa-times-circle">.

There may be other modals that suffer the same issue - so worth a find/replace for "icon-remove-sign" across the whole code base.

UAT screen shot 2019-01-24 at 12 36 02

PROD screen shot 2019-01-24 at 12 35 58

krupalip commented 5 years ago

Hi @keithmoss , I couldn't see orgs on dataset page. image

keithamoss commented 5 years ago

It wasn't organisations specifically, but more the contents of the whole filter sidebar. Also it was a responsive design issue - so you'll have to use your browser's dev tools to see it.

Here's a GIF demonstrating:

uat-ckan-responsive-dialog-no-close-button

krupalip commented 5 years ago

oh I see. I will have look. Thanks

krupalip commented 5 years ago

fixed. it was font awesome icon name.