search

datawhalechina / torch-rechub

A Lighting Pytorch Framework for Recommendation Models, Easy-to-use and Easy-to-extend.
MIT License
374 stars 69 forks source link

Mistake in preprocess_ali_ccp.py #35

Closed wyhwhy closed 1 year ago

wyhwhy commented 1 year ago

In Line 81, vocabulary[k][v] should be set to 1 at first to coordinate with Line 90 (which should be >=10, for example). In this case the TRUE threshold is 12 now.

yinpu commented 1 year ago

@wyhwhy Thanks for noticing this detail, we will fix this mistake. We appreciate all contributions to improve torch-rechub. Welcome to participate in this project.

wyhwhy commented 1 year ago

@wyhwhy Thanks for noticing this detail, we will fix this mistake. We appreciate all contributions to improve torch-rechub. Welcome to participate in this project.

Thanks for rely