Fix CI, rename the CRD files, and fuss with their formatting a bit

datawire / ambassador-chart

Helm Chart for Installing Ambassador

42 stars 60 forks source link

Fix CI, rename the CRD files, and fuss with their formatting a bit #108

Closed LukeShu closed 4 years ago

LukeShu commented 4 years ago

This should be all no-op changes.

This will make the diffs for the upcoming 1.6 a lot easier, trust me :)

And apparently, k3d renamed their master branch to main, and that broke CI here, so I had to adjust that.

kflynn commented 4 years ago

Looks good from here, over to @nbkrause. 🙂

LukeShu commented 4 years ago

Removing
annotations:
  "helm.sh/hook": crd-install
breaks helm2 support for installing CRDs.

I want to remove them as well but we need another solution than just removing support for helm2.

I didn't remove it? I just let Python sort the keys, so annotations comes first in the metadata instead of last.

iNoahNothing commented 4 years ago

Removing
annotations:
  "helm.sh/hook": crd-install
breaks helm2 support for installing CRDs. I want to remove them as well but we need another solution than just removing support for helm2.
I didn't remove it? I just let Python sort the keys, so annotations comes first in the metadata instead of last.

Oh I am an idiot 🤦