search

datawire / ambassador-chart

Helm Chart for Installing Ambassador
42 stars 60 forks source link

Add Container securityContext options to Prometheus Exporter container #139

Closed lorenzo-biava closed 4 years ago

lorenzo-biava commented 4 years ago

For security reasons (e.g. setting readOnlyRootFilesystem), we need to set the securityContext in all the containers and while the Ambassador one has it, the Prometheus Exporter is lacking the option.

It would be helpful to have a dedicated option like .Values.prometheusExporter.security.containerSecurityContext or at least reuse the existing one for the Ambassador container.

lorenzo-biava commented 4 years ago

Just realized that the Prom Exporter is deprecated; never mind.