search

datawire / kubernaut

Instant ephemeral Kubernetes clusters for development and testing
Apache License 2.0
117 stars 8 forks source link

add export message #18

Closed richarddli closed 6 years ago

richarddli commented 7 years ago

quick fix to address https://github.com/datawire/kubernaut/issues/10

(my #1 gripe about kubernaut ... since i never remember the export)

plombardi89 commented 7 years ago

This needs a bit more work. It does not account for the type of shell you're using so for example, I and @ark3 use Fish rather than Bash and that has a different export syntax. I am aware of this issue and I have begun work on it in the next major feature branch: https://github.com/datawire/kubernaut/blob/dev/multicluster/kubernaut/claims/commands.py#L44

We should support Bash, Zsh and Fish export syntaxes. These are as far as I am aware the three most common shells out there (Zsh being common enough to get command completion for kubectl).

Two options:

  1. Update the PR to account for Fish and Zsh. The logic is probably very similar to what is shown in the command above
  2. Wait for the next release (~1 week out from now... hopefully).