search

datawire / teleproxy

18 stars 9 forks source link

k8s-args: Part 2A: Add {{image}} function to kubeapply #154

Closed LukeShu closed 5 years ago

LukeShu commented 5 years ago

This is factored out from @rhs's #140, for separate reviewing.

I also backported some build-aux changes from apro, to fix make clobber, since when testing this PR, I realized that make clobber was broken (which was my fault).

I also had to modify the Makefile to get make check to work, because @rhs had buried essential stuff in .circleci/.

LukeShu commented 5 years ago

I don't like teaching kubeapply to build Docker images. That's giving it too much smarts. We should teach it how to have a function that says "I depend on this thing, call out to my stub to go build it".

But, I'll accept this in the mean-time, for purposes of expediency; as supporting work for the rest of this patch series.