search

datawire / teleproxy

18 stars 9 forks source link

edgectl: Fix Mac outbound and add an outbound smoke test #173

Closed ark3 closed 5 years ago

ark3 commented 5 years ago

Trying #167 again using direct calls to the edgectl binary. This includes a fix for MacOS (using sudo instead of su) that shouldn't have to be a special case, i.e. the same code should work on Linux but does not (at least for me).

Note that Mac CI is b0rked, even for master. A commit that passed CI ~11 days ago now fails consistently. The Mac CI environment itself has changed in a way that appears to be incompatible with current Teleproxy.

LukeShu commented 5 years ago

LGTM, but I'm not clicking "Approve" because I know @rhs was pretty opposed to calling out to Make when it came up over at https://github.com/datawire/teleproxy/pull/168#discussion_r317693372 so I'm not really comfortable clicking "Approve" on this without his OK.

ark3 commented 5 years ago

Once it becomes possible to call Teleproxy as a function (in a Goroutine) instead of as a subprocess, I should be able to rejigger things so that building the executable won't be necessary. I don't think it makes sense to hold up having smoke tests for that. How about I file an issue about this ("Edge Control smoke tests should not build and use the edgectl binary") once we land this PR?