search

datawookie / www-exegetic-biz

Website for Exegetic Analytics
https://www.exegetic.biz
0 stars 3 forks source link

Another monstrous pull. #88

Closed Axiematic closed 4 years ago

datawookie commented 4 years ago

Hi @Axiematic,

Okay, whew! This is huge. I've taken another look and I'm generally happy with this. Some parts of this really need to go live ASAP. But...

  1. There are some change requests that have not been dealt with (all relating to using Hugo shortcodes for links rather than hard-coded paths).
  2. Let's try not to let this happen again. Rather make a pull request after every feature has been completed. So do something, check that it works/looks good and then immediately create a pull request.

Please let's sort this out ASAP on Tuesday.

Thanks, Dad.

Axiematic commented 4 years ago

Hi @datawookie

  1. None of the shortcode methods seem to work in the front matter. I've done some extensive Googling and can't seem to find a solution other than just using the original links.
datawookie commented 4 years ago

Ah, shit. How annoying.

Okay, I'm going to merge this. Please check on the site tomorrow morning to ensure that nothing had broken.

And let's keep these PR short and sweet in future.

Axiematic commented 4 years ago

@datawookie everything looks good to me :).