search

dataxfi / dapp

DataX Dapp Frontend
dapp-olive.vercel.app
0 stars 0 forks source link

Resolve all React console warnings #98

Open keithfrazier98 opened 2 years ago

keithfrazier98 commented 2 years ago

With the current deployment of Datapolis, there are numerous console warnings regarding dependency arrays on useEffects, or other similar warnings from React that all show in the console when running on localhost. Ideally, while developing these warnings are monitored and handled. Currently, there are unresolved warnings that when resolved will result in the safest instance of deployment and will allow the CI environment variable in Vercel to be set to true. This env variables dictates whether Vercel treats console warnings as errors and unless it is explicitly set to false, the deployment will fail.

0xaki commented 2 years ago

dapp repo issues

keithfrazier98 commented 2 years ago

This issue was addressed in commit ccfe0f1d4488720dcbcf9e9ad44a1c1be28ccf64. Pending review and will close issue once deployed with main.