datchley / react-scale-text

A React library to keep an element's text scaled to fit it's container
MIT License
54 stars 18 forks source link

Improve Unit Test Coverage #3

Closed datchley closed 7 years ago

datchley commented 7 years ago

Our unit test coverage is abysmal, at best, and our unit tests are lacking due to how hard it is to mock DOM related dimension functionality with jest and jsdom. I'm currently looking for a way to factor these DOM related pieces out or to minimize the DOM api surface area needed by the component to both improve the ability to unit test and improve coverage.

datchley commented 7 years ago

Taken care of with #4 - moving to mocha + electron to handle the unit testing on this component due to the need for browser layout related apis.