date-fns / date-fns.org

🏡 date-fns website 🌈
https://date-fns.org
MIT License
55 stars 32 forks source link

Docs Bug: Deep links don't jump to the relevant heading #151

Closed alexilyaev closed 3 years ago

alexilyaev commented 4 years ago

I'm trying to send a colleague a deep link to one of the heading in the docs, but when the link is opened the page does not jump to that heading.

e.g. https://date-fns.org/v2.10.0/docs/parse#syntax

Expected to jump to the Syntax heading, which is towards the bottom of the page. This is relevant across the whole docs website.

Tested on Chrome/Firefox/Safari on macOS.

I suppose since the site is not server side rendered, the url hash feature won't work in the browser, so it needs to be implemented with JavaScript on render finish.