search

datenanfragen / backend

While Datenanfragen.de is mostly run as a static site, some functionality does require a server. These endpoints are defined here.
MIT License
4 stars 6 forks source link

Comment rating should be a number #53

Open zner0L opened 2 years ago

zner0L commented 2 years ago

Apparently, the backend currently treats rating numbers as strings. This makes no sense, as pointed out by this comment: https://github.com/datenanfragen/website/pull/872/files#diff-79762f6bf029b23635833cbb41d691bdb1913a7d8e6a5ce6727b706c5acb0d57R17

baltpeter commented 2 years ago

Iirc, the problem is that Knex returns everything as a string and we need to convert it to a number manually.

See: https://github.com/datenanfragen/backend/pull/20