Closed mal-tee closed 1 year ago
I have:
Do we need to set slugs for the required
.md
files incontent
?
No. In fact, I prefer to use the English slugs, but some translators wanted to translate them. But if you don't set a slug, you don't need aliases for the English slugs either.
I had to commit this via
--no-verify
, since eslint complained about seemingly unrelated stuff. Probably because this PR touched these for the first time since we introduced new rules?
Um, I can't reproduce that. I only get a few warnings that we should fix but have been there for a while (we should really go the -Werror
route, warnings don't work).
But I did fix the TypeScript errors that were the cause for this problem:
Seems to deploy without every translation for the new language in i18n-widget, but it only shows an empty string.
You didn't provide a translation for language-desc-cs
, that's what's shown in the I18nWidget
.
Other than that, I didn't look at your commit, I'll leave that to @zner0L.
Fixes #773
TODO
i18n-widget
, but it only shows an empty string.Comment
.md
files incontent
?--no-verify
, since eslint complained about seemingly unrelated stuff. Probably because this PR touched these for the first time since we introduced new rules?eslint error output
``` ✖ eslint --ext .json --ext .js --ext .jsx --ext .ts --ext .tsx: /home/mal/dade/website/components-package/src/index.ts 5:37 error Unable to resolve path to module './generated/globals.json' import/no-unresolved 7:25 error Unable to resolve path to module '../package.json' import/no-unresolved /home/mal/dade/website/deploy-dattel.js 1:19 error Requires 'eslint-enable' directive for 'no-console' eslint-comments/disable-enable-pair 21:55 error '_' is defined but never used @typescript-eslint/no-unused-vars ```