Closed mal-tee closed 3 months ago
We should completely block email addresses in the "Name" field.
We should completely block email addresses in the "Name" field.
How about pattern='[^@]+'
for the input field?
I'm not sure whether you can provide a custom message for that.
Do we want to allow other handles in the url that might look like emails? E.g. mastodon or matrix handles.
I don't think that's necessary. From my perspective, the name field is not meant for attribution or being able to contact the other, but only to be able to distinguish comments from different people.
@baltpeter gentle bump, I think getting this merged will save us a lot of annoyances in our inboxes :D
Oh wow, embarrassing how much time has passed already. Sorry. :|
In the interest of getting this landed, I've made a few more changes myself. If you're happy with them, @mal-tee, this can be merged.
Sure, thanks!
You were quicker than the tests. :D If I forget, feel free to merge yourself once they're done.
Passing run #5790 ↗︎
Details:
e689149b51
Review all test suite changes for PR #1126 ↗︎