datenanfragen / website

The Datenanfragen.de website including the request PDF generator and company information database
https://www.datenanfragen.de
MIT License
88 stars 126 forks source link

Warn about likely unintentional comments #1126

Closed mal-tee closed 3 months ago

cypress[bot] commented 6 months ago

Passing run #5790 ↗︎

0 80 8 0 Flakiness 0

Details:

squash benni's changes
Project: datenanfragen/website Commit: e689149b51
Status: Passed Duration: 03:38 💡
Started: Mar 12, 2024 6:45 PM Ended: Mar 12, 2024 6:49 PM

Review all test suite changes for PR #1126 ↗︎

mal-tee commented 5 months ago

todo

baltpeter commented 5 months ago

We should completely block email addresses in the "Name" field.

mal-tee commented 5 months ago

We should completely block email addresses in the "Name" field.

How about pattern='[^@]+' for the input field?

baltpeter commented 5 months ago

I'm not sure whether you can provide a custom message for that.

mal-tee commented 5 months ago

Do we want to allow other handles in the url that might look like emails? E.g. mastodon or matrix handles.

baltpeter commented 5 months ago

I don't think that's necessary. From my perspective, the name field is not meant for attribution or being able to contact the other, but only to be able to distinguish comments from different people.

mal-tee commented 3 months ago

@baltpeter gentle bump, I think getting this merged will save us a lot of annoyances in our inboxes :D

baltpeter commented 3 months ago

Oh wow, embarrassing how much time has passed already. Sorry. :|

In the interest of getting this landed, I've made a few more changes myself. If you're happy with them, @mal-tee, this can be merged.

mal-tee commented 3 months ago

Sure, thanks!

baltpeter commented 3 months ago

You were quicker than the tests. :D If I forget, feel free to merge yourself once they're done.