search

datenanfragen / website

The Datenanfragen.de website including the request PDF generator and company information database
https://www.datenanfragen.de
MIT License
95 stars 125 forks source link

Scrolling on the company database is broken for mobile #357

Open mal-tee opened 4 years ago

mal-tee commented 4 years ago

If you search for a term on the database, you might not be able to see all results, because you can not scroll. Instead of moving the view, the list of all companies in the background is moved.

In this example you can only see the first three results, instead of all five.

grafik

hadron43 commented 4 years ago

Hello. Can I take this? Please add more info, the page on which the issue exists.

zner0L commented 4 years ago

Sure, have at it! You can find the issue here: https://www.datarequests.org/company

Files you might want to look at are layouts/company/list.html and src/company-list.js

hadron43 commented 4 years ago

Please assign me.

hadron43 commented 4 years ago

While building, I'm facing the following error. Any suggestions? Start building sites … ERROR 2020/10/02 17:35:56 TOCSS: failed to transform "styles/loader.scss" (text/x-scss): resource "scss/styles/loader.scss_16daf05a51a1b3e21f08cb57cd3d16ce" not found in file cache Built in 4354 ms Error: Error building site: TOCSS: failed to transform "styles/main.scss" (text/x-scss): resource "scss/styles/main.scss_16daf05a51a1b3e21f08cb57cd3d16ce" not found in file cache

baltpeter commented 4 years ago

Make sure you're using the Extended version of Hugo. That should fix the error.

hadron43 commented 4 years ago

What kind of behavior is expected? Shall I remove the "Our company database holds the contract..." line when the div becomes sticky? But it still won't guarantee proper functioning.

Another option is to reduce the number of search results to 3, which I guess will be complicated to implement.

zner0L commented 4 years ago

I think there are two things you can do: hide the text and button when scrolling and implement proper overflow handling for the search results. You can also try and limit the amount of search results based on the screen size, but I feel like this could end up being pretty error prone.

hadron43 commented 4 years ago

I hope this fixes it. Please review.